Change in osmo-bts[master]: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence

Alexander Chemeris gerrit-no-reply at lists.osmocom.org
Thu May 9 16:22:14 UTC 2019


Alexander Chemeris has posted comments on this change. ( https://gerrit.osmocom.org/13723 )

Change subject: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence
......................................................................


Patch Set 4:

> I really appreciate all the comments, and will consider yet not
 > addressed ones as the points of further improvements, but now I
 > really need to move this fix forward. It's really annoying to see
 > 11-bit Access Bursts decoded as 8-bit ones, and vice versa. Adding
 > my CR+2 & V+1 for now, going to merge in a few hours (unless
 > anybody has any strong objections).

I would appreciate if you remove comparison from the weight calculation code as we discussed. You'd be surprised how many RACHs can a BTS get in a congested situation.


-- 
To view, visit https://gerrit.osmocom.org/13723
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb6d27c6589965c8b59a6d2598a7c43fd860f284
Gerrit-Change-Number: 13723
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Max <suraev at alumni.ntnu.no>
Gerrit-Comment-Date: Thu, 09 May 2019 16:22:14 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190509/1e5f37ef/attachment.html>


More information about the gerrit-log mailing list