Change in osmo-msc[master]: LOG_TRANS: store subsys in trans, unify USSD logging back to DMM

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu May 9 14:34:08 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13941 )

Change subject: LOG_TRANS: store subsys in trans, unify USSD logging back to DMM
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

https://gerrit.osmocom.org/#/c/13941/1/include/osmocom/msc/transaction.h
File include/osmocom/msc/transaction.h:

https://gerrit.osmocom.org/#/c/13941/1/include/osmocom/msc/transaction.h@173
PS1, Line 173: deserves its own logging subsystem
ACK!


https://gerrit.osmocom.org/#/c/13941/1/src/libmsc/transaction.c
File src/libmsc/transaction.c:

https://gerrit.osmocom.org/#/c/13941/1/src/libmsc/transaction.c@149
PS1, Line 149: trans->log_subsys = trans_log_subsys(trans);
Good optimization.



-- 
To view, visit https://gerrit.osmocom.org/13941
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dfe5b98fb9e884c2dde61d603832dafceb12123
Gerrit-Change-Number: 13941
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 09 May 2019 14:34:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190509/51488f28/attachment.html>


More information about the gerrit-log mailing list