Change in osmo-ttcn3-hacks[master]: msc: Permit optional authentication before reject/timeout

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu May 9 11:45:35 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13936 )

Change subject: msc: Permit optional authentication before reject/timeout
......................................................................

msc: Permit optional authentication before reject/timeout

Tests like TC_lu_imsi_reject, TC_lu_imsi_timeout_gsup and
TC_cmserv_imsi_unknown all expected a reject straight in response
to the LU REQ / CM SERV REQ.  However, the MSC may very well decide
to perform authentication beforehand.  It's an implementation
detail when a MSC/VLR performs authentication, so the tests should
be tolerant to this.

This primarily shows up in 3G/Iu/RANAP related tests, as authentication
is mandatory there.

Change-Id: Icdd3f34eca08092703ab2ba9a8e755e2d609a59b
---
M msc/MSC_Tests.ttcn
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 52aa685..e1e5088 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -583,6 +583,7 @@
 
 	f_create_gsup_expect(hex2str(g_pars.imsi));
 	f_cl3_or_initial_ue(l3_lu);
+	f_mm_auth();
 	GSUP.receive(tr_GSUP_UL_REQ(g_pars.imsi));
 	GSUP.send(ts_GSUP_UL_ERR(g_pars.imsi, 23));
 	alt {
@@ -612,6 +613,7 @@
 
 	f_create_gsup_expect(hex2str(g_pars.imsi));
 	f_cl3_or_initial_ue(l3_lu);
+	f_mm_auth();
 	GSUP.receive(tr_GSUP_UL_REQ(g_pars.imsi));
 	/* Normally the HLR would need to respond here, but we decide to force a timeout here */
 	alt {
@@ -678,6 +680,7 @@
 
 	/* Send BSSAP_Conn_Req with COMPL L3 INFO to MSC */
 	f_cl3_or_initial_ue(l3_info);
+	f_mm_auth();
 
 	timer T := 10.0;
 	T.start;

-- 
To view, visit https://gerrit.osmocom.org/13936
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icdd3f34eca08092703ab2ba9a8e755e2d609a59b
Gerrit-Change-Number: 13936
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190509/ecf8b981/attachment.html>


More information about the gerrit-log mailing list