Change in osmo-bts[master]: handle NULL return from rate_ctr_group_alloc()

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed May 8 22:17:14 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13911 )

Change subject: handle NULL return from rate_ctr_group_alloc()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13911/1/src/common/bts.c
File src/common/bts.c:

https://gerrit.osmocom.org/#/c/13911/1/src/common/bts.c@126
PS1, Line 126: 		llist_del(&bts->list);
> What about moving llist_add_tail to the end and then dropping this llist_del together with the one i […]
I'm aware of that option.  However, in these kind of "trivial bug fix" changes, I try to avoid being too smart and go for the most straight-forward solution.



-- 
To view, visit https://gerrit.osmocom.org/13911
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2170e400e47369e9171af4c7361aa2177fea1174
Gerrit-Change-Number: 13911
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 08 May 2019 22:17:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190508/6fb1ac3a/attachment.html>


More information about the gerrit-log mailing list