Change in osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() w/o MM ctx

Keith Whyte gerrit-no-reply at lists.osmocom.org
Wed May 8 17:50:56 UTC 2019


Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13929 )

Change subject: libgtp: don't call sgsn_pdp_ctx_free() w/o MM ctx
......................................................................


Patch Set 1: Code-Review-1

see OS#3956

I don't know if this would deal with the issue, or if there's a reason to call sgsn_pdp_ctx_free() anyway, even if !pctx->mm

There's also a talloc_free(pdp) in sgsn_pdp_ctx_free() and I'm not sure if skipping that is a leak.


-- 
To view, visit https://gerrit.osmocom.org/13929
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I184dcce27b26104c61d80b2d910388d5d3323def
Gerrit-Change-Number: 13929
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-CC: Jenkins Builder (1000002)
Gerrit-Comment-Date: Wed, 08 May 2019 17:50:56 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190508/2ccaed07/attachment.html>


More information about the gerrit-log mailing list