Change in libosmocore[master]: Print error message if application fails to call rate_ctr_init()

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed May 8 17:27:10 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13919 )

Change subject: Print error message if application fails to call rate_ctr_init()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13919/1/src/rate_ctr.c
File src/rate_ctr.c:

https://gerrit.osmocom.org/#/c/13919/1/src/rate_ctr.c@220
PS1, Line 220: 	if (!osmo_timer_pending(&rate_ctr_timer))
> I think you ended up putting some stuff from this patch into the previous one.
no, the patch is "correct" in the sense that it does what it's supposed to do, IMHO ?1?



-- 
To view, visit https://gerrit.osmocom.org/13919
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8093b66b7e27cf863d2558fe21b2c6e0f3fcdfd
Gerrit-Change-Number: 13919
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 08 May 2019 17:27:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190508/bed76d79/attachment.html>


More information about the gerrit-log mailing list