Change in libosmocore[master]: Print error message if application fails to call rate_ctr_init()

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed May 8 15:01:23 UTC 2019


Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13919


Change subject: Print error message if application fails to call rate_ctr_init()
......................................................................

Print error message if application fails to call rate_ctr_init()

Change-Id: Ie8093b66b7e27cf863d2558fe21b2c6e0f3fcdfd
Closes: OS#3580
---
M src/rate_ctr.c
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/19/13919/1

diff --git a/src/rate_ctr.c b/src/rate_ctr.c
index 90e6502..99ec523 100644
--- a/src/rate_ctr.c
+++ b/src/rate_ctr.c
@@ -217,6 +217,10 @@
 	unsigned int size;
 	struct rate_ctr_group *group;
 
+	if (!osmo_timer_pending(&rate_ctr_timer))
+		LOGP(DLGLOBAL, LOGL_ERROR, "your program appears to use libosmocore rate_ctr "
+			"without calling rate_ctr_init() at start-up. Rate counters won't work!\n");
+
 	if (rate_ctr_get_group_by_name_idx(desc->group_name_prefix, idx)) {
 		unsigned int new_idx = rate_ctr_get_unused_name_idx(desc->group_name_prefix);
 		LOGP(DLGLOBAL, LOGL_ERROR, "counter group '%s' already exists for index %u,"

-- 
To view, visit https://gerrit.osmocom.org/13919
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8093b66b7e27cf863d2558fe21b2c6e0f3fcdfd
Gerrit-Change-Number: 13919
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190508/2bfff3e6/attachment.html>


More information about the gerrit-log mailing list