Change in osmo-hlr[master]: db_hlr.c: db_subscr_create(): nam_cs, nam_ps args

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Wed May 8 14:01:38 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13711 )

Change subject: db_hlr.c: db_subscr_create(): nam_cs, nam_ps args
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/13711/2/src/db.h
File src/db.h:

https://gerrit.osmocom.org/#/c/13711/2/src/db.h@121
PS2, Line 121: int nam_cs, int nam_ps
Alternatively, we could have a bitmask here, so we would be able to extend it later on. In particular:

  #define SUBSCR_FLAG_NAM_CS (1 << 0)
  #define SUBSCR_FLAG_NAM_PS (1 << 1)

  ...

  int db_subscr_create(..., uint8_t flags);

and the function call itself would look cleaner:

  /* Create a subscriber with both CS and PS domains allowed */
  db_subscr_create(..., SUBSCR_FLAG_NAM_CS | SUBSCR_FLAG_NAM_PS);


https://gerrit.osmocom.org/#/c/13711/2/src/db.h@121
PS2, Line 121: int
Since this is just yes or no, you could use bool.


https://gerrit.osmocom.org/#/c/13711/2/src/db_hlr.c
File src/db_hlr.c:

https://gerrit.osmocom.org/#/c/13711/2/src/db_hlr.c@47
PS2, Line 47: (1: enable, 0: disable)
... so there would be no need to clarify possible values.



-- 
To view, visit https://gerrit.osmocom.org/13711
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a6dd85387723dab5487c53b33d2d9ec6d05d006
Gerrit-Change-Number: 13711
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 08 May 2019 14:01:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190508/f8bd41f8/attachment.html>


More information about the gerrit-log mailing list