Change in osmo-hlr[master]: Create subscribers on demand

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Wed May 8 13:54:16 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13713 )

Change subject: Create subscribers on demand
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/13713/2/src/hlr.c
File src/hlr.c:

https://gerrit.osmocom.org/#/c/13713/2/src/hlr.c@154
PS2, Line 154: 15
AFAIR, I just used a random number, because in the original patch the MSISDN length was hard-coded. Do we have any constant like MSISDN_MAX_LEN in libosmocore or wherever?

In any case, we're limited by OSMO_MAX_RAND_ID_LEN (16).


https://gerrit.osmocom.org/#/c/13713/2/src/hlr.c@178
PS2, Line 178: continue
I just realized that we may end up with an infinity loop here, if osmo_get_rand_id() constantly fails. Probably, we need to limit the amount of attempts somehow...



-- 
To view, visit https://gerrit.osmocom.org/13713
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c9fe93f5c24b5e9fefb513c4d049fb7ebd47ecd
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 08 May 2019 13:54:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190508/fdb22a6f/attachment.html>


More information about the gerrit-log mailing list