Change in libosmocore[master]: gsm0808_utils: Introduce gsm0808_msgb_put_cell_id_u()

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed May 8 13:46:10 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13887 )

Change subject: gsm0808_utils: Introduce gsm0808_msgb_put_cell_id_u()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13887/1/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:

https://gerrit.osmocom.org/#/c/13887/1/src/gsm/gsm0808_utils.c@802
PS1, Line 802: 		gsm0808_msgb_put_cell_id_u(msg, cil->id_discr, &cil->id_list[i]);
> Can you really have different id_discr in encoding of list in CBSP? Otherwise it makes sense to keep […]
the "probelm" in CBSP is that there are two types of lists: One where there's a single global "discr" followed by a list of items of identical type.  There's also other lists where each element in the list has a separate "discr" inside the element.  And in order to supprot both from a single encode/decode function, we need to leave list iteration to the user and pass in the discr into the function.



-- 
To view, visit https://gerrit.osmocom.org/13887
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc567798e20365e6587e6b2988e834306d8c80c
Gerrit-Change-Number: 13887
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 08 May 2019 13:46:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190508/9b69e180/attachment.html>


More information about the gerrit-log mailing list