Change in osmo-mgw[master]: osmux: Document func and return different rc upon osmux init failure

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed May 8 13:37:01 UTC 2019


Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13917


Change subject: osmux: Document func and return different rc upon osmux init failure
......................................................................

osmux: Document func and return different rc upon osmux init failure

Change-Id: Id8593bc374b598e63a70c60ac256273b9d99ba6e
---
M src/libosmo-mgcp/mgcp_protocol.c
1 file changed, 6 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/17/13917/1

diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c
index bfb88bc..3a4e396 100644
--- a/src/libosmo-mgcp/mgcp_protocol.c
+++ b/src/libosmo-mgcp/mgcp_protocol.c
@@ -671,12 +671,17 @@
 	    rtp->codec->frame_duration_den;
 }
 
+/*! Initializes osmux socket if not yet initialized. Parses Osmux CID from MGCP line.
+ *  \param[in] endp Endpoint willing to initialize osmux
+ *  \param[in] line Line X-Osmux from MGCP header msg to parse
+ *  \returns OSMUX CID, -1 for wildcard, -2 on parse error, -3 on osmux initalize error
+ */
 static int mgcp_osmux_setup(struct mgcp_endpoint *endp, const char *line)
 {
 	if (!endp->cfg->osmux_init) {
 		if (osmux_init(OSMUX_ROLE_BSC, endp->cfg) < 0) {
 			LOGPENDP(endp, DLMGCP, LOGL_ERROR, "Cannot init OSMUX\n");
-			return -1;
+			return -3;
 		}
 		LOGPENDP(endp, DLMGCP, LOGL_NOTICE, "OSMUX socket has been set up\n");
 	}

-- 
To view, visit https://gerrit.osmocom.org/13917
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8593bc374b598e63a70c60ac256273b9d99ba6e
Gerrit-Change-Number: 13917
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190508/e943a159/attachment.html>


More information about the gerrit-log mailing list