Change in osmo-msc[master]: vlr: optionally send IMEI early to HLR
gerrit-no-reply at lists.osmocom.org
Wed May 8 11:34:55 UTC 2019
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13894 )
Change subject: vlr: optionally send IMEI early to HLR
Patch Set 1:
PS1, Line 932: LOGPFSM(fi, "%s()\n", __func__);
> I've added it for consistency with related functions, that also log just their function name. […]
ok, I think there's some point to the consistency argument here. So whether you put it here or not, I don't care. But I'm generally doubtful we want to have log statement at every function invocation. That's what one can do with debuggers and tracers. But that's a general discussion.
PS1, Line 955: event without effect
> It is done like this 6 other times in the file already, so I'd keep that for consistency.
let's please submit an unrelated cleanup patch to change those other locations to OSMO_ASSERT(0), too.
To view, visit https://gerrit.osmocom.org/13894
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 08 May 2019 11:34:55 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log