Change in openbsc[master]: nat: Allocate bsc_nat_parsed on the stack instead of heap

Holger Freyther gerrit-no-reply at lists.osmocom.org
Wed May 8 04:10:04 UTC 2019


Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/13843 )

Change subject: nat: Allocate bsc_nat_parsed on the stack instead of heap
......................................................................


Patch Set 3:

(1 comment)

Looks good. I think we should have consistency about the success and error space and maybe return a boolean directly. WDUT?

https://gerrit.osmocom.org/#/c/13843/3/openbsc/src/osmo-bsc_nat/bsc_nat.c
File openbsc/src/osmo-bsc_nat/bsc_nat.c:

https://gerrit.osmocom.org/#/c/13843/3/openbsc/src/osmo-bsc_nat/bsc_nat.c@703
PS3, Line 703: <
What about != 0 like in many other cases (e.g. the write queue success tests)? This would match the bool success = ... == 0 behavior further down. Or return a boolean directly?



-- 
To view, visit https://gerrit.osmocom.org/13843
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66c44890952339f15131081e2f629a2824b6d3ba
Gerrit-Change-Number: 13843
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Wed, 08 May 2019 04:10:04 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190508/f60707a9/attachment.html>


More information about the gerrit-log mailing list