Change in osmo-msc[master]: large refactoring: support inter-BSC and inter-MSC Handover

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue May 7 22:22:16 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13137 )

Change subject: large refactoring: support inter-BSC and inter-MSC Handover
......................................................................


Patch Set 9:

(23 comments)

https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:

https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@156
PS9, Line 156: DEBUGP
How about LOG_MSC_A_CAT() here?


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@164
PS9, Line 164: DEBUGP
How about LOG_MSC_A_CAT() here?


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@201
PS9, Line 201: LOGP
How about LOG_MSC_A_CAT() here?


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@206
PS9, Line 206: DEBUGP
How about LOG_MSC_A_CAT() here?


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@279
PS9, Line 279: switch
if (gsm48_hdr_msg_type(gh) != GSM48_MT_RR_PAG_RESP)
  return -1;


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@409
PS9, Line 409: 		msc_a_put(msc_a, __func__);
Shouldn't we also msc_a_put(MSC_A_USE_LOCATION_UPDATING) here?


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@416
PS9, Line 416: 		msc_a_put(msc_a, __func__);
Shouldn't we also msc_a_put(MSC_A_USE_LOCATION_UPDATING) here?


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@615
PS9, Line 615: DEBUGP
What about LOG_MSC_A() here?


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@617
PS9, Line 617: DEBUGP
What about LOG_MSC_A() here?


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@677
PS9, Line 677: 		     gsm48_mi_type_name(mi_type), mi_string);
Still unaligned: one space is missing.


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@719
PS9, Line 719: 			 msg->data_len, sizeof(struct gsm48_service_request*));
Fancy alignment needs one more space ;)


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@719
PS9, Line 719: sizeof(struct gsm48_service_request*)
Wait, sizeof pointer?!? Looks like a bug.


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@808
PS9, Line 808: DEBUGP
What about LOG_MSC_A() here?


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@825
PS9, Line 825: DEBUGP
What about LOG_MSC_A() here?


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@850
PS9, Line 850: 
ws


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@852
PS9, Line 852: LOGP
What about LOG_MSC_A() here?


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@855
PS9, Line 855: LOGP
What about LOG_MSC_A() here?


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@890
PS9, Line 890: 			     msgb_l3len(msg));
Broken alignment: +1 space.


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@921
PS9, Line 921: msgb_l3len(msg)
I think it should be data_len.


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@969
PS9, Line 969: 		     "MM AUTHENTICATION RESPONSE: invalid: parsing %s AKA Auth Response"
Broken alignment.


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@1202
PS9, Line 1202: DEBUGP
What about LOG_MSC_A()?


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@1244
PS9, Line 1244: DEBUGP
What about LOG_MSC_A()?


https://gerrit.osmocom.org/#/c/13137/9/src/libmsc/gsm_04_08.c@1302
PS9, Line 1302: cm_service_type
Unused?



-- 
To view, visit https://gerrit.osmocom.org/13137
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I27e4988e0371808b512c757d2b52ada1615067bd
Gerrit-Change-Number: 13137
Gerrit-PatchSet: 9
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 07 May 2019 22:22:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190507/1fe100a4/attachment.html>


More information about the gerrit-log mailing list