Change in libosmocore[master]: Fix osmo_quote_str_c() for strings larger than 32 bytes

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue May 7 16:18:33 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13901 )

Change subject: Fix osmo_quote_str_c() for strings larger than 32 bytes
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/13901/1/src/utils.c
File src/utils.c:

https://gerrit.osmocom.org/#/c/13901/1/src/utils.c@816
PS1, Line 816: 	/* some minimum length for things like "NULL" or "(error)" */
-1 case is still not handle corrected, see my previous email in ML about it:


char *osmo_quote_str_c(const void *ctx, const char *str, int in_len)
{
    size_t len = in_len == -1 ? strlen(str) : in_len;
    len += 2;
    char *buf = talloc_size(ctx, len);
    if (!buf)
        return NULL;
    return osmo_quote_str_buf2(buf, len, str, in_len);
}



-- 
To view, visit https://gerrit.osmocom.org/13901
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9bde14166d6674ce4dda36fa9f4ae9217ce5cc2
Gerrit-Change-Number: 13901
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 07 May 2019 16:18:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190507/75e8507a/attachment.html>


More information about the gerrit-log mailing list