Change in osmo-hlr[master]: hlr.c: fix: properly print the original message type in read_cb_forwa...

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue May 7 14:18:09 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13898 )

Change subject: hlr.c: fix: properly print the original message type in read_cb_forward()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13898/1/src/hlr.c
File src/hlr.c:

https://gerrit.osmocom.org/#/c/13898/1/src/hlr.c@502
PS1, Line 502: 		LOGP_GSUP_FWD(gsup_err, LOGL_ERROR, "destination not connected\n");
Why not using gsup here instead of gsup_err, and then moving all gsup_err allocation after "end" tag?



-- 
To view, visit https://gerrit.osmocom.org/13898
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1db1e089fc0f8e03653a9f05058e95d2adaee39
Gerrit-Change-Number: 13898
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 07 May 2019 14:18:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190507/17cc0ece/attachment.html>


More information about the gerrit-log mailing list