Change in osmo-hlr[master]: osmo-hlr: allow configuring db path from cfg file

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue May 7 13:17:00 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13586 )

Change subject: osmo-hlr: allow configuring db path from cfg file
......................................................................


Patch Set 4:

(1 comment)

(comment on earlier patch set)

https://gerrit.osmocom.org/#/c/13586/1/src/hlr.c
File src/hlr.c:

https://gerrit.osmocom.org/#/c/13586/1/src/hlr.c@739
PS1, Line 739: 
> Makes sense, took me a while to understand what you mean. […]
no, can't. The g_hlr->db_file_path needs to be a talloc allocated string from the start.
This first populates the NULL string with a talloc string.
So we can't make this conditional.

That said, maybe you are confused by the "replace", instead I could assign a talloc string directly, because I know anyway that it is always NULL here.



-- 
To view, visit https://gerrit.osmocom.org/13586
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87b8673324e1e6225afb758fb4963ff3279ea3d8
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 07 May 2019 13:17:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190507/7c5e06b2/attachment.html>


More information about the gerrit-log mailing list