Change in osmo-msc[master]: vlr: check IMEI early for retrieve-imeisv-early 1

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue May 7 13:00:21 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13894 )

Change subject: vlr: check IMEI early for retrieve-imeisv-early 1
......................................................................


Patch Set 1:

(3 comments)

Fine in general, just a few not critical notes.

https://gerrit.osmocom.org/#/c/13894/1/src/libvlr/vlr_lu_fsm.c
File src/libvlr/vlr_lu_fsm.c:

https://gerrit.osmocom.org/#/c/13894/1/src/libvlr/vlr_lu_fsm.c@932
PS1, Line 932: LOGPFSM(fi, "%s()\n", __func__);
What would this message mean for a regular user (not a developer)? Either it should contain something more informative, or it should be removed.


https://gerrit.osmocom.org/#/c/13894/1/src/libvlr/vlr_lu_fsm.c@937
PS1, Line 937: }
             : 	else
Please fix the coding style: ... } else { ...


https://gerrit.osmocom.org/#/c/13894/1/src/libvlr/vlr_lu_fsm.c@955
PS1, Line 955: event without effect
I guess if this happens, then we have a bug somewhere? I would rather OSMO_ASSERT(0) here... Not critical though.



-- 
To view, visit https://gerrit.osmocom.org/13894
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88283cad23793b475445d814ff49db534cb41244
Gerrit-Change-Number: 13894
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 07 May 2019 13:00:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190507/d31c1cc4/attachment.html>


More information about the gerrit-log mailing list