Change in docker-playground[master]: Add OSMO_*_BRANCH environment variables for build args

osmith gerrit-no-reply at lists.osmocom.org
Tue May 7 10:25:18 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/13779 )

Change subject: Add OSMO_*_BRANCH environment variables for build args
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13779/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/13779/1//COMMIT_MSG@15
PS1, Line 15: The origin/ prefix from the git checkout command is removed so the
            : *_BRANCH variable doesn't have to contain branch names, but van also
            : contain arbitrary commits. This shouldn't have any adverse effect as we
            : only have one remote in the checkout.
This breaks using branch names in these variables:

 $ git checkout -f -B osmith/check-imei-before-lu osmith/check-imei-before-lu
 fatal: Cannot update paths and switch to branch 'osmith/check-imei-before-lu' at the same time.
 Did you intend to checkout 'osmith/check-imei-before-lu' which can not be resolved as commit?

Fix submitted here: https://gerrit.osmocom.org/#/c/docker-playground/+/13895/



-- 
To view, visit https://gerrit.osmocom.org/13779
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3bc5fae07cf63c4fef68306be4c4328660bc869
Gerrit-Change-Number: 13779
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 07 May 2019 10:25:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190507/49f86514/attachment.html>


More information about the gerrit-log mailing list