Change in libosmocore[master]: gsm0808_utils: Add gsm0808_decode_cell_id_u()

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue May 7 08:46:07 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13888 )

Change subject: gsm0808_utils: Add gsm0808_decode_cell_id_u()
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/13888/1/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:

https://gerrit.osmocom.org/#/c/13888/1/src/gsm/gsm0808_utils.c@761
PS1, Line 761: 		if (len < 7)
would be good to known where do this sizes come from. Perhaps we have some structs we can use with sizeof() here?


https://gerrit.osmocom.org/#/c/13888/1/src/gsm/gsm0808_utils.c@796
PS1, Line 796: }
Just to make sure: It is intendeded that "discr" is not set somewhere inside "out"? In order to have together which values are avaialable with the values (as in a variant let's say).



-- 
To view, visit https://gerrit.osmocom.org/13888
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b33881667aa32f01e53ccb70d44d5b79c7c986
Gerrit-Change-Number: 13888
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 07 May 2019 08:46:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190507/bf7cb6e5/attachment.html>


More information about the gerrit-log mailing list