Change in osmo-msc[master]: fix various missing line endings in logging

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon May 6 21:45:45 UTC 2019


Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13890


Change subject: fix various missing line endings in logging
......................................................................

fix various missing line endings in logging

Change-Id: I013eb0eeb5673c06034465020e5dc5230f45ddf5
---
M src/libmsc/gsm_04_11.c
M src/libvlr/vlr.c
M src/libvlr/vlr_access_req_fsm.c
3 files changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/90/13890/1

diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c
index da0744a..71069dc 100644
--- a/src/libmsc/gsm_04_11.c
+++ b/src/libmsc/gsm_04_11.c
@@ -425,7 +425,7 @@
 			/* unknown subscriber, try local */
 			goto try_local;
 		if (rc < 0) {
-			LOG_TRANS(trans, LOGL_ERROR, "SMS delivery error: %d.", rc);
+			LOG_TRANS(trans, LOGL_ERROR, "SMS delivery error: %d\n", rc);
 	 		rc = GSM411_RP_CAUSE_MO_TEMP_FAIL;
 			/* rc will be logged by gsm411_send_rp_error() */
 			rate_ctr_inc(&conn->network->msc_ctrs->ctr[
@@ -451,7 +451,7 @@
 		if (rc == GSM411_RP_CAUSE_MO_NUM_UNASSIGNED) {
 			rate_ctr_inc(&conn->network->msc_ctrs->ctr[MSC_CTR_SMS_NO_RECEIVER]);
 		} else if (rc < 0) {
-			LOG_TRANS(trans, LOGL_ERROR, "SMS delivery error: %d.", rc);
+			LOG_TRANS(trans, LOGL_ERROR, "SMS delivery error: %d\n", rc);
 	 		rc = GSM411_RP_CAUSE_MO_TEMP_FAIL;
 			/* rc will be logged by gsm411_send_rp_error() */
 			rate_ctr_inc(&conn->network->msc_ctrs->ctr[
diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index 1afdbec..c6d8805 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -1241,7 +1241,7 @@
 					      PR_ARQ_E_TMSI_ACK, NULL);
 	} else {
 		LOGVSUBP(LOGL_NOTICE, vsub,
-			 "gratuitous TMSI REALLOC COMPL");
+			 "gratuitous TMSI REALLOC COMPL\n");
 		return -EINVAL;
 	}
 }
diff --git a/src/libvlr/vlr_access_req_fsm.c b/src/libvlr/vlr_access_req_fsm.c
index 3040158..fccb6d3 100644
--- a/src/libvlr/vlr_access_req_fsm.c
+++ b/src/libvlr/vlr_access_req_fsm.c
@@ -141,7 +141,7 @@
 	 * will start handling pending paging transactions. */
 
 	if (!fi->proc.parent) {
-		LOGPFSML(fi, LOGL_ERROR, "No parent FSM");
+		LOGPFSML(fi, LOGL_ERROR, "No parent FSM\n");
 		return;
 	}
 	osmo_fsm_inst_dispatch(fi->proc.parent,

-- 
To view, visit https://gerrit.osmocom.org/13890
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I013eb0eeb5673c06034465020e5dc5230f45ddf5
Gerrit-Change-Number: 13890
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190506/c56f5754/attachment.html>


More information about the gerrit-log mailing list