Change in osmo-bts[master]: common/oml.c: fix: properly encode NM_ATT_SW_CONFIG

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Mon May 6 17:42:34 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13709 )

Change subject: common/oml.c: fix: properly encode NM_ATT_SW_CONFIG
......................................................................


Patch Set 4:

(2 comments)

> agreeing with pau

I forgot to commit my changes before pushing, please see the new version.

https://gerrit.osmocom.org/#/c/13709/2/src/common/oml.c
File src/common/oml.c:

https://gerrit.osmocom.org/#/c/13709/2/src/common/oml.c@164
PS2, Line 164: 	}
> better use osmo_store16be, len may not be aligned?
Sure, thanks! Done.


https://gerrit.osmocom.org/#/c/13709/2/src/common/oml.c@190
PS2, Line 190: 	total_len = abis_nm_put_sw_file(msg, btsatttr2str(TRX_PHY_VERSION), phy_version, true);
> same as comment above.
Done.



-- 
To view, visit https://gerrit.osmocom.org/13709
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id26104719891944f3e2151df362bd45bb057a9c5
Gerrit-Change-Number: 13709
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 06 May 2019 17:42:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190506/e4d6bf1b/attachment.html>


More information about the gerrit-log mailing list