Change in libosmocore[master]: Re-introduce declaration of gsm0808_create_handover_request_ack()

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon May 6 08:40:31 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13882 )

Change subject: Re-introduce declaration of gsm0808_create_handover_request_ack()
......................................................................

Re-introduce declaration of gsm0808_create_handover_request_ack()

In Change-Id Ia71542ea37d4fd2c9fb9b40357db7aeb111ec576, the old
declaration of gsm0808_create_handover_request_ack() was accidentially
removed from the gsm0808.h header file.  The actual function itself
(and the exported symbol) remained for backwards compatibility at
runtime, but removing the declaration from the header file resulted in
build failures across the board of all automatic tests.

Let's re-introduce the old declaration.

Change-Id: I9e96fa675fccca9ee9631caad7559dea3794d490
---
M include/osmocom/gsm/gsm0808.h
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h
index 93195b5..373b434 100644
--- a/include/osmocom/gsm/gsm0808.h
+++ b/include/osmocom/gsm/gsm0808.h
@@ -194,6 +194,10 @@
 };
 struct msgb *gsm0808_create_handover_request(const struct gsm0808_handover_request *params);
 
+struct msgb *gsm0808_create_handover_request_ack(const uint8_t *l3_info, uint8_t l3_info_len,
+						 uint8_t chosen_channel, uint8_t chosen_encr_alg,
+						 uint8_t chosen_speech_version);
+
 struct gsm0808_handover_request_ack {
 	const uint8_t *l3_info;
 	uint8_t l3_info_len;

-- 
To view, visit https://gerrit.osmocom.org/13882
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e96fa675fccca9ee9631caad7559dea3794d490
Gerrit-Change-Number: 13882
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190506/7bfb1c9d/attachment.html>


More information about the gerrit-log mailing list