Change in osmo-ttcn3-hacks[master]: msc: mo and mt voice call tests: add lots of missing parts

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sun May 5 16:27:20 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13616 )

Change subject: msc: mo and mt voice call tests: add lots of missing parts
......................................................................


Patch Set 4: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/#/c/13616/4/msc/BSC_ConnectionHandler.ttcn
File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/#/c/13616/4/msc/BSC_ConnectionHandler.ttcn@486
PS4, Line 486: log("f_mt_call_complete 1");
Is there any way to make such messages more informative than '1', '2', ...? For example, I would love to see something like:

  "BSC_ConnectionHandler.ttcn:$LINE | f_mt_call_complete(): established BSSMAP connection"


https://gerrit.osmocom.org/#/c/13616/4/msc/BSC_ConnectionHandler.ttcn@494
PS4, Line 494: log("f_mt_call_complete 2");
Same here, e.g.:

  "BSC_ConnectionHandler.ttcn:$LINE | f_mt_call_complete(): Received (MS -> MSC) ALERTING"


https://gerrit.osmocom.org/#/c/13616/4/msc/BSC_ConnectionHandler.ttcn@503
PS4, Line 503: log("f_mt_call_complete 3");
Same here, e.g.:

  "BSC_ConnectionHandler.ttcn:$LINE | f_mt_call_complete(): Received first MGCP CRCX (for BSS/RAN side)"


https://gerrit.osmocom.org/#/c/13616/4/msc/BSC_ConnectionHandler.ttcn@542
PS4, Line 542: 	
ws



-- 
To view, visit https://gerrit.osmocom.org/13616
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I162985045bb5e129977a3a797b656e30220990df
Gerrit-Change-Number: 13616
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sun, 05 May 2019 16:27:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190505/d80a23dd/attachment.html>


More information about the gerrit-log mailing list