Change in libosmocore[master]: osmo_gsup_decode(): properly check IMSI, avoid deprecation

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sun May 5 11:46:30 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13817 )

Change subject: osmo_gsup_decode(): properly check IMSI, avoid deprecation
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/13817/2/src/gsm/gsup.c
File src/gsm/gsup.c:

https://gerrit.osmocom.org/#/c/13817/2/src/gsm/gsup.c@330
PS2, Line 330: gsm48_decode_bcd_number
Should we also correct this?



-- 
To view, visit https://gerrit.osmocom.org/13817
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaded84d91baad5386c8f353c283b6b9e40a43b05
Gerrit-Change-Number: 13817
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sun, 05 May 2019 11:46:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190505/97f15bf8/attachment.html>


More information about the gerrit-log mailing list