This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13871 ) Change subject: Introduce LOGCHAN macro to standarize logging channel info ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/#/c/13871/2/CommonLibs/Logger.h File CommonLibs/Logger.h: https://gerrit.osmocom.org/#/c/13871/2/CommonLibs/Logger.h@59 PS2, Line 59: Cosmetic: let's rather have this \n after the macro, not here. https://gerrit.osmocom.org/#/c/13871/2/Transceiver52M/device/lms/LMSDevice.cpp File Transceiver52M/device/lms/LMSDevice.cpp: https://gerrit.osmocom.org/#/c/13871/2/Transceiver52M/device/lms/LMSDevice.cpp@577 PS2, Line 577: << m_last_rx_underruns[chan] << " -> " : << status.underrun << ")"; Please realign. https://gerrit.osmocom.org/#/c/13871/2/Transceiver52M/device/lms/LMSDevice.cpp@585 PS2, Line 585: << m_last_rx_overruns[chan] << " -> " : << status.overrun << ")"; Please realign. https://gerrit.osmocom.org/#/c/13871/2/Transceiver52M/device/lms/LMSDevice.cpp@592 PS2, Line 592: << m_last_rx_dropped[chan] << " -> " : << status.droppedPackets << ")"; Please realign. -- To view, visit https://gerrit.osmocom.org/13871 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67d869499aa16af58c863ca7b74c356bcd979936 Gerrit-Change-Number: 13871 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Sun, 05 May 2019 07:20:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190505/7580298a/attachment.htm>