Change in osmo-trx[master]: smpl_buf: Move it to device/common and create libdevice_common.la

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Sat May 4 18:36:16 UTC 2019


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/13873

to look at the new patch set (#2).

Change subject: smpl_buf: Move it to device/common and create libdevice_common.la
......................................................................

smpl_buf: Move it to device/common and create libdevice_common.la

Since in next commit osmo-trx-lms starts using smpl_buf.cpp, it seems
some automake step doesn't like including a cpp file twice from a
different directory, since race conditions can occur building it.
Instead we define the dependency by first building a static lib and then
using it on each libdevice.la (one per device type).

We already do the similar under arch/ subdir, where we have a common/
subdir and then one subdir and lib per architecture.

Change-Id: I465ad0f6d5569bb3006d711c8fd0df14391fcf35
---
M Transceiver52M/Makefile.am
M Transceiver52M/device/Makefile.am
A Transceiver52M/device/common/Makefile.am
R Transceiver52M/device/common/radioDevice.h
R Transceiver52M/device/common/smpl_buf.cpp
R Transceiver52M/device/common/smpl_buf.h
M Transceiver52M/device/lms/Makefile.am
M Transceiver52M/device/uhd/Makefile.am
M Transceiver52M/device/usrp1/Makefile.am
M configure.ac
10 files changed, 20 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/73/13873/2
-- 
To view, visit https://gerrit.osmocom.org/13873
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I465ad0f6d5569bb3006d711c8fd0df14391fcf35
Gerrit-Change-Number: 13873
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190504/8c8c63b8/attachment.html>


More information about the gerrit-log mailing list