Change in osmo-trx[master]: lms: Use smpl_buf to recover from timestamp jumps

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri May 3 19:39:02 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13872 )

Change subject: lms: Use smpl_buf to recover from timestamp jumps
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/13872/2/Transceiver52M/device/lms/LMSDevice.cpp
File Transceiver52M/device/lms/LMSDevice.cpp:

https://gerrit.osmocom.org/#/c/13872/2/Transceiver52M/device/lms/LMSDevice.cpp@61
PS2, Line 61: 	rx_buffers.resize(chans);
> I'd stick with the file naming convention of using m_ prefix for members.
I'm reusing same naming already used in UHDDevice to simplify understanding for readers and showing it's the same var.



-- 
To view, visit https://gerrit.osmocom.org/13872
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfc4e69acc30afb11440b6b9cbdcfa09ff920265
Gerrit-Change-Number: 13872
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Fri, 03 May 2019 19:39:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190503/547445ca/attachment.html>


More information about the gerrit-log mailing list