Change in openbsc[master]: nat: Allocate bsc_nat_parsed on the stack instead of heap

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri May 3 10:12:53 UTC 2019


Hello Jenkins Builder, Holger Freyther, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/13843

to look at the new patch set (#3).

Change subject: nat: Allocate bsc_nat_parsed on the stack instead of heap
......................................................................

nat: Allocate bsc_nat_parsed on the stack instead of heap

There's no real need to allocate it using talloc. Allocating it on the
stack simplifies the code, avoids mem leaks and makes it faster.

Change-Id: I66c44890952339f15131081e2f629a2824b6d3ba
---
M openbsc/include/openbsc/bsc_nat.h
M openbsc/src/osmo-bsc_nat/bsc_filter.c
M openbsc/src/osmo-bsc_nat/bsc_nat.c
M openbsc/src/osmo-bsc_nat/bsc_nat_rewrite.c
M openbsc/src/osmo-bsc_nat/bsc_ussd.c
M openbsc/tests/bsc-nat/bsc_nat_test.c
6 files changed, 129 insertions(+), 169 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/43/13843/3
-- 
To view, visit https://gerrit.osmocom.org/13843
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I66c44890952339f15131081e2f629a2824b6d3ba
Gerrit-Change-Number: 13843
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190503/08a77cf9/attachment.html>


More information about the gerrit-log mailing list