Change in osmocom-bb[master]: mobile/gsm48_mm.c: use proper types for gsm48_rr_hdr

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu May 2 22:58:03 UTC 2019


Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13857


Change subject: mobile/gsm48_mm.c: use proper types for gsm48_rr_hdr
......................................................................

mobile/gsm48_mm.c: use proper types for gsm48_rr_hdr

Change-Id: I29ed122b8956260b9f847cc0e3e81a28d6762632
---
M src/host/layer23/src/mobile/gsm48_mm.c
1 file changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/57/13857/1

diff --git a/src/host/layer23/src/mobile/gsm48_mm.c b/src/host/layer23/src/mobile/gsm48_mm.c
index 02d861e..872dce5 100644
--- a/src/host/layer23/src/mobile/gsm48_mm.c
+++ b/src/host/layer23/src/mobile/gsm48_mm.c
@@ -3583,7 +3583,7 @@
  */
 
 static int gsm48_rcv_rr_sapi3(struct osmocom_ms *ms, struct msgb *msg,
-	int msg_type, uint8_t sapi)
+			      uint32_t msg_type, uint8_t sapi)
 {
 	struct gsm48_mmlayer *mm = &ms->mmlayer;
 	struct gsm48_mm_conn *conn;
@@ -3895,12 +3895,12 @@
 {
 	struct gsm48_mmlayer *mm = &ms->mmlayer;
 	struct gsm48_rr_hdr *rrh = (struct gsm48_rr_hdr *)msg->data;
-	int msg_type = rrh->msg_type;
-	int sapi = rrh->sapi;
+	uint32_t msg_type = rrh->msg_type;
+	uint8_t sapi = rrh->sapi;
 	int i, rc;
 
 	LOGP(DMM, LOGL_INFO, "(ms %s) Received '%s' from RR in state %s "
-		"(sapi %d)\n", ms->name, get_rr_name(msg_type),
+		"(sapi %u)\n", ms->name, get_rr_name(msg_type),
 		gsm48_mm_state_names[mm->state], sapi);
 
 	if (sapi)
@@ -3969,7 +3969,7 @@
 {
 	struct gsm48_mmlayer *mm = &ms->mmlayer;
 	struct gsm48_rr_hdr *rrh = (struct gsm48_rr_hdr *)msg->data;
-	int sapi = rrh->sapi;
+	uint8_t sapi = rrh->sapi;
 	struct gsm48_hdr *gh = msgb_l3(msg);
 	uint8_t pdisc = gh->proto_discr & 0x0f;
 	uint8_t msg_type = gh->msg_type & 0xbf;

-- 
To view, visit https://gerrit.osmocom.org/13857
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I29ed122b8956260b9f847cc0e3e81a28d6762632
Gerrit-Change-Number: 13857
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190502/572ccacd/attachment.html>


More information about the gerrit-log mailing list