Change in openbsc[master]: bsc_nat: Fix crash (double-free) in forward_sccp_to_msc

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu May 2 09:01:34 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13837 )

Change subject: bsc_nat: Fix crash (double-free) in forward_sccp_to_msc
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13837/1/openbsc/src/osmo-bsc_nat/bsc_nat.c
File openbsc/src/osmo-bsc_nat/bsc_nat.c:

https://gerrit.osmocom.org/#/c/13837/1/openbsc/src/osmo-bsc_nat/bsc_nat.c@1284
PS1, Line 1284: 	
> What happens if we change the order of the two calls? […]
Which two calls do you mean? talloc_free(parsed) and queue_for_msc()? Good point, that would work too and it'd be more simple, I'll change the commit. I'll still leave the return type in queue_for_msc since it can be helpful for later.

Regarding parsed allocation, I think the best would actually be simplifying the code by having parsed allocated in the stack and have
"""int bsc_nat_parse(struct msgb *msg, struct bsc_nat_parsed *parsed)"""
instead of 
"""struct bsc_nat_parsed *bsc_nat_parse(struct msgb *msg)"""
I can submit a commit as a follow-up to this one doing so.



-- 
To view, visit https://gerrit.osmocom.org/13837
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I209d3e2d809a67915ec43c874e68f7f746a565f0
Gerrit-Change-Number: 13837
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Holger Freyther <holger at freyther.de>
Gerrit-Comment-Date: Thu, 02 May 2019 09:01:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190502/58ceb0a6/attachment.html>


More information about the gerrit-log mailing list