Change in osmo-gsm-tester[master]: virtual: Separate starting virtphy/mobile from the test

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed May 1 11:38:41 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13823 )

Change subject: virtual: Separate starting virtphy/mobile from the test
......................................................................


Patch Set 1:

With this bunch of patches submitted I have the general impression:
* Too many suff in every patch, it's difficult to follow and I'd welcome more fine-grained ones in the future.
* You are trying to add steps into every test but under the "osmo-gsm-tester test" level, so internal to your tests. I wonder that it'd be better having this kind of stuff generic (at suite and test level) rather than inside it.

But since you are mostly the only one playing with osmo_ms_driver subdir and related stuff I guess it's fine to leave it be and eveolve as you want there for now. It's going to be easier to try adding that to osmo-gsm-tester generic part and we can always do that later.


-- 
To view, visit https://gerrit.osmocom.org/13823
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie15f5123775d11dd44243b2741d047ed93f318f9
Gerrit-Change-Number: 13823
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 01 May 2019 11:38:41 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190501/9d98778c/attachment.html>


More information about the gerrit-log mailing list