Change in osmo-trx[master]: uhd: No need to use dynamic mem for rx_buffers

tnt gerrit-no-reply at lists.osmocom.org
Wed May 1 06:26:51 UTC 2019


tnt has posted comments on this change. ( https://gerrit.osmocom.org/13833 )

Change subject: uhd: No need to use dynamic mem for rx_buffers
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

I'd like to make sure you tried running the multi-channel case with this patch first, because I suspect that might break it.

https://gerrit.osmocom.org/#/c/13833/1/Transceiver52M/device/uhd/UHDDevice.cpp
File Transceiver52M/device/uhd/UHDDevice.cpp:

https://gerrit.osmocom.org/#/c/13833/1/Transceiver52M/device/uhd/UHDDevice.cpp@512
PS1, Line 512: 	rx_buffers = std::vector<smpl_buf>(chans, smpl_buf(buf_len, rx_rate));
My C++ is rusty but are you sure this works ?
Won't that just use the default copy constructore for smpl_buf and so you'll end up with several buffer pointing to the same data array ?



-- 
To view, visit https://gerrit.osmocom.org/13833
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39b293c24053298256626fa78344102032fc2104
Gerrit-Change-Number: 13833
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Wed, 01 May 2019 06:26:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190501/35d9b338/attachment.html>


More information about the gerrit-log mailing list