Change in osmo-msc[master]: Write configuration correctly from vty (alert notifications)

Keith Whyte gerrit-no-reply at lists.osmocom.org
Fri Mar 29 22:48:38 UTC 2019


Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13321 )

Change subject: Write configuration correctly from vty (alert notifications)
......................................................................

Write configuration correctly from vty (alert notifications)

The default is [yes] alert-notifications, therefore write
"no alert-notifications" in the case that this has
been set, in order to preserve configuration after
write is called from vty.

Change-Id: I079aea96ee83fbf04f782dcab344d41a4ef04657
---
M src/libmsc/smpp_vty.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Keith Whyte: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/libmsc/smpp_vty.c b/src/libmsc/smpp_vty.c
index 4c179d4..9026f6c 100644
--- a/src/libmsc/smpp_vty.c
+++ b/src/libmsc/smpp_vty.c
@@ -582,8 +582,8 @@
 		vty_out(vty, "  osmocom-extensions%s", VTY_NEWLINE);
 	if (acl->dcs_transparent)
 		vty_out(vty, "  dcs-transparent%s", VTY_NEWLINE);
-	if (acl->alert_notifications)
-		vty_out(vty, "  alert-notifications%s", VTY_NEWLINE);
+	if (!acl->alert_notifications)
+		vty_out(vty, "  no alert-notifications%s", VTY_NEWLINE);
 
 	llist_for_each_entry(r, &acl->route_list, list)
 		write_esme_route_single(vty, r);

-- 
To view, visit https://gerrit.osmocom.org/13321
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I079aea96ee83fbf04f782dcab344d41a4ef04657
Gerrit-Change-Number: 13321
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190329/1832bd32/attachment.html>


More information about the gerrit-log mailing list