Change in openbsc[master]: Write configuration correctly from vty (alert notifications)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Keith Whyte gerrit-no-reply at lists.osmocom.org
Fri Mar 29 18:58:21 UTC 2019


Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13320 )

Change subject: Write configuration correctly from vty (alert notifications)
......................................................................

Write configuration correctly from vty (alert notifications)

The default is [yes] alert-notifications, therefore write
"no alert-notifications" in the case that this has
been set, in order to preserve configuration after
write is called from vty.

Change-Id: I4b0363fa34dd9ac0a221844974e4ebf7465b56f4
---
M openbsc/src/libmsc/smpp_vty.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/libmsc/smpp_vty.c b/openbsc/src/libmsc/smpp_vty.c
index f1df652..8647867 100644
--- a/openbsc/src/libmsc/smpp_vty.c
+++ b/openbsc/src/libmsc/smpp_vty.c
@@ -582,8 +582,8 @@
 		vty_out(vty, "  osmocom-extensions%s", VTY_NEWLINE);
 	if (acl->dcs_transparent)
 		vty_out(vty, "  dcs-transparent%s", VTY_NEWLINE);
-	if (acl->alert_notifications)
-		vty_out(vty, "  alert-notifications%s", VTY_NEWLINE);
+	if (!acl->alert_notifications)
+		vty_out(vty, "  no alert-notifications%s", VTY_NEWLINE);
 
 	llist_for_each_entry(r, &acl->route_list, list)
 		write_esme_route_single(vty, r);

-- 
To view, visit https://gerrit.osmocom.org/13320
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b0363fa34dd9ac0a221844974e4ebf7465b56f4
Gerrit-Change-Number: 13320
Gerrit-PatchSet: 6
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-CC: Max <suraev at alumni.ntnu.no>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190329/8be89b6e/attachment.htm>


More information about the gerrit-log mailing list