Change in osmo-msc[master]: libmsc/sms_queue.c: fix memleak in smsq_take_next_sms()

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Mar 29 14:51:58 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13450 )

Change subject: libmsc/sms_queue.c: fix memleak in smsq_take_next_sms()
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/13450/2/src/libmsc/sms_queue.c
File src/libmsc/sms_queue.c:

https://gerrit.osmocom.org/#/c/13450/2/src/libmsc/sms_queue.c@233
PS2, Line 233: 			talloc_free(sms);
sms->receiver is a reference to a vlr_subscr with a use count. You are now leaking that use count. Use sms_free() instead.



-- 
To view, visit https://gerrit.osmocom.org/13450
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad5e4d84d8d410ea43d5907e9ddf6e5fdb55bc7a
Gerrit-Change-Number: 13450
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 29 Mar 2019 14:51:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190329/e3fd9f16/attachment.html>


More information about the gerrit-log mailing list