Change in libosmocore[master]: osmo_escape_str_buf: Always copy, don't return input string pointer

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Mar 28 12:59:33 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13447 )

Change subject: osmo_escape_str_buf: Always copy, don't return input string pointer
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/13447/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/13447/1//COMMIT_MSG@10
PS1, Line 10: if no escaping was needed, it would return the original pointe without
typo: pointer


https://gerrit.osmocom.org/#/c/13447/1//COMMIT_MSG@11
PS1, Line 11: making any copy to the output buffer.  While this seems like a elegant
an elegant



-- 
To view, visit https://gerrit.osmocom.org/13447
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a02bdb27008a73101c2db41ac04248960ed4064
Gerrit-Change-Number: 13447
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Mar 2019 12:59:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190328/74577fea/attachment.html>


More information about the gerrit-log mailing list