Change in openbsc[master]: Replace broken ipa_ccm_idtag APIs with new ipa_ccm_id ones

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Mar 28 12:24:08 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13433 )

Change subject: Replace broken ipa_ccm_idtag APIs with new ipa_ccm_id ones
......................................................................


Patch Set 2:

> looks good to me.  However, we should have at least some very basic
 > bsc-nat tests in operation (Daniel?) before merging a change like
 > this.

I could manually test with the VTY NAT tests that it's working better than it used to. I saw parsing working correctly on those paths which used to fail. I think it's fine merging right now.


-- 
To view, visit https://gerrit.osmocom.org/13433
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b995f8ef0b48c0a5b3375e42926641934359cd2
Gerrit-Change-Number: 13433
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Assignee: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Mar 2019 12:24:08 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190328/a861e616/attachment.html>


More information about the gerrit-log mailing list