Change in osmo-msc[master]: Add vty option to globally enable LCLS

osmith gerrit-no-reply at lists.osmocom.org
Thu Mar 28 10:32:47 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/13421 )

Change subject: Add vty option to globally enable LCLS
......................................................................


Patch Set 6:

(2 comments)

Review points addressed.

I'm wondering if we should add some kind of warning, that the option has no effect yet. I don't see a follow up patch, that will actually use this option, so it seems like it will stay in this state for some time.

https://gerrit.osmocom.org/#/c/13421/5/include/osmocom/msc/vlr.h
File include/osmocom/msc/vlr.h:

https://gerrit.osmocom.org/#/c/13421/5/include/osmocom/msc/vlr.h@277
PS5, Line 277: enable_lcls;
> Cosmetic: other symbols here are using imperative style, so "enable_lcls" would be better.
Done


https://gerrit.osmocom.org/#/c/13421/5/src/libmsc/msc_vty.c
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/#/c/13421/5/src/libmsc/msc_vty.c@408
PS5, Line 408: lcls enable
> Are you (you anyone else) going to add more LCLS related parameters? If yes, it would make sense to  […]
Done. I went with this instead of '"lcls-mode (disable|enable-all)"' proposed by Harald, because "lcls enable" seems more flexible to me.



-- 
To view, visit https://gerrit.osmocom.org/13421
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb587e6ae47cff71f5bf2e2d22c1da86cd7e1762
Gerrit-Change-Number: 13421
Gerrit-PatchSet: 6
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Assignee: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 28 Mar 2019 10:32:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190328/e0d63989/attachment.html>


More information about the gerrit-log mailing list