Change in osmo-msc[master]: Add vty option to globally enable LCLS

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Wed Mar 27 20:27:37 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13421 )

Change subject: Add vty option to globally enable LCLS
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.osmocom.org/#/c/13421/5/include/osmocom/msc/vlr.h
File include/osmocom/msc/vlr.h:

https://gerrit.osmocom.org/#/c/13421/5/include/osmocom/msc/vlr.h@277
PS5, Line 277: lcls_enabled
Cosmetic: other symbols here are using imperative style, so "enable_lcls" would be better.


https://gerrit.osmocom.org/#/c/13421/5/src/libmsc/msc_vty.c
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/#/c/13421/5/src/libmsc/msc_vty.c@408
PS5, Line 408: lcls-enable
Are you (you anyone else) going to add more LCLS related parameters? If yes, it would make sense to have group called 'lcls', so the command would look this way: "lcls enable 1" or similar.



-- 
To view, visit https://gerrit.osmocom.org/13421
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb587e6ae47cff71f5bf2e2d22c1da86cd7e1762
Gerrit-Change-Number: 13421
Gerrit-PatchSet: 5
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Assignee: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 27 Mar 2019 20:27:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190327/13ee2da0/attachment.html>


More information about the gerrit-log mailing list