This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Daniel Willmann gerrit-no-reply at lists.osmocom.orgDaniel Willmann has submitted this change and it was merged. ( https://gerrit.osmocom.org/13358 ) Change subject: OC-2G: Fix TA adjustment ...................................................................... OC-2G: Fix TA adjustment Problem: TA provided from L1 PH-DATA-IND is a relative amount of TA adjustment to actual TA being used for given TBF. The current TA update algorithm in PCU simply applies the relative amount of TA to given TBF but does not take into account of current TA. As a result, the PCU will request wrong TA jump for given TBF if the MS is moving away from BTS more than 2 km. Related issue: http://osmocom.org/issues/2611 Fixes: - The PCU needs increase or decrease current TA of given TBF on receiving of relative amount of TA adjustment provided by PH-DATA-IND from L1. - The PCU needs to set absolute TA of given TBF on receiving absolute TA provided by PH-RA-IND from L1. From-Commit: 139ad3f42193 From-Remote: https://gitlab.com/nrw_noa/osmo-pcu Change-Id: I7665586dd5722bbe04632ee5673d3033bc082324 --- M src/osmo-bts-oc2g/oc2g_l1_if.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bts-oc2g/oc2g_l1_if.c b/src/osmo-bts-oc2g/oc2g_l1_if.c index 3855da1..ccf7431 100644 --- a/src/osmo-bts-oc2g/oc2g_l1_if.c +++ b/src/osmo-bts-oc2g/oc2g_l1_if.c @@ -210,7 +210,7 @@ get_meas(&meas, &data_ind->measParam); bts_update_tbf_ta("PH-DATA", data_ind->u32Fn, fl1h->trx_no, - data_ind->u8Tn, qta2ta(meas.bto)); + data_ind->u8Tn, sign_qta2ta(meas.bto), false); switch (data_ind->sapi) { case GsmL1_Sapi_Pdtch: @@ -250,7 +250,7 @@ DEBUGP(DL1IF, "Rx PH-RA.ind"); bts_update_tbf_ta("PH-RA", ra_ind->u32Fn, fl1h->trx_no, ra_ind->u8Tn, - qta2ta(ra_ind->measParam.i16BurstTiming)); + sign_qta2ta(ra_ind->measParam.i16BurstTiming), true); return 0; } -- To view, visit https://gerrit.osmocom.org/13358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7665586dd5722bbe04632ee5673d3033bc082324 Gerrit-Change-Number: 13358 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Willmann <dwillmann at sysmocom.de> Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190327/cf13ec5f/attachment.htm>