Change in osmo-pcu[master]: MCS: add Channel Coding Command encoder

Max gerrit-no-reply at lists.osmocom.org
Wed Mar 27 12:32:00 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/13215 )

Change subject: MCS: add Channel Coding Command encoder
......................................................................


Patch Set 6:

(1 comment)

Let's do it in a separate patch though to avoid going through weel-long review cycle again over essentially cosmetic change.

https://gerrit.osmocom.org/#/c/13215/6/tests/tbf/TbfTest.cpp
File tests/tbf/TbfTest.cpp:

https://gerrit.osmocom.org/#/c/13215/6/tests/tbf/TbfTest.cpp@2740
PS6, Line 2740: 		OSMO_ASSERT(mcs_chan_code(tbf->m_rlc.block(bsn)->cs_current_trans) == cs - 1); \
> This new check looks really cryptic, at least it deserves come comment.
I don't think it looks any more cryptic than before but adding comment won't hurt.



-- 
To view, visit https://gerrit.osmocom.org/13215
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I127fb29f5aaf77a7f6c4c565dfeb3b711af9845d
Gerrit-Change-Number: 13215
Gerrit-PatchSet: 6
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Mar 2019 12:32:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190327/6fc3299f/attachment.html>


More information about the gerrit-log mailing list