Change in osmo-bsc[master]: nanobts: use libosmocore's osmo_store*() for OML attr. patching
gerrit-no-reply at lists.osmocom.org
Wed Mar 27 12:26:28 UTC 2019
Max has posted comments on this change. ( https://gerrit.osmocom.org/13418 )
Change subject: nanobts: use libosmocore's osmo_store*() for OML attr. patching
Patch Set 1:
Not sure this will have a chance to significantly improve until we have some actual users running Osmocom stack on Power processors (or alike).
PS1, Line 202: buf = bts->gprs.nsvc.nsvci >> 8;
> your assessment appears correct. This should be fixed in an independent patch/fix.
I agree. Ideally we should also try to build and use it on some BE CPU (Power 9?) - I'm pretty sure this will reveal more issues where code compiles fine but does not do what's expected. For example in OsmoBTS pcu_sock.c (and it's copy in OsmoBSC) there're warnings about *l_tbf_ext endianness which seems to be due to the way PCU in nanobts expects that data.
To view, visit https://gerrit.osmocom.org/13418
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Mar 2019 12:26:28 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log