This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgMax has posted comments on this change. ( https://gerrit.osmocom.org/13418 ) Change subject: nanobts: use libosmocore's osmo_store*() for OML attr. patching ...................................................................... Patch Set 1: (1 comment) Not sure this will have a chance to significantly improve until we have some actual users running Osmocom stack on Power processors (or alike). https://gerrit.osmocom.org/#/c/13418/1/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c: https://gerrit.osmocom.org/#/c/13418/1/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c@202 PS1, Line 202: buf[0] = bts->gprs.nsvc[0].nsvci >> 8; > your assessment appears correct. This should be fixed in an independent patch/fix. I agree. Ideally we should also try to build and use it on some BE CPU (Power 9?) - I'm pretty sure this will reveal more issues where code compiles fine but does not do what's expected. For example in OsmoBTS pcu_sock.c (and it's copy in OsmoBSC) there're warnings about *l_tbf_ext endianness which seems to be due to the way PCU in nanobts expects that data. -- To view, visit https://gerrit.osmocom.org/13418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28cfb09f224072db9889a89923a3da15a6070e2a Gerrit-Change-Number: 13418 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 27 Mar 2019 12:26:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190327/828aff51/attachment.htm>