Change in osmo-ttcn3-hacks[master]: pcu: Ensure we're always using the same defaults for the CGI

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 27 11:17:50 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13375 )

Change subject: pcu: Ensure we're always using the same defaults for the CGI
......................................................................

pcu: Ensure we're always using the same defaults for the CGI

Not all parts of the code explicitly specify each and every parameter
of the Cell Gobal Identifier (particularly we don't do that for the PCU
INFO IND), and hence multiple parts only interoperate if the same
defaults are used in all locations.

Change-Id: Iac9be9a8d4ccb4d01cc343d763d2e35873e3844f
---
M library/PCUIF_Types.ttcn
M pcu/PCU_Tests.default
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn
index 5644431..0c3f000 100644
--- a/library/PCUIF_Types.ttcn
+++ b/library/PCUIF_Types.ttcn
@@ -657,9 +657,9 @@
 						 template (value) PCUIF_Flags flags := c_PCUIF_Flags_default,
 						 template (value) uint16_t mcc := 262,
 						 template (value) uint16_t mnc := 42,
-						 template (value) uint16_t lac := 2342,
+						 template (value) uint16_t lac := 13135,
 						 template (value) uint8_t rac := 0,
-						 template (value) uint16_t cell_id := 1,
+						 template (value) uint16_t cell_id := 20960,
 						 template (value) uint8_t bsic := 7,
 						 template (value) PCUIF_InfoTrxs trx := ts_PCUIF_InfoTrxs_def,
 						 template (value) uint32_t version := PCU_IF_VERSION) := {
diff --git a/pcu/PCU_Tests.default b/pcu/PCU_Tests.default
index a877045..67c05f8 100644
--- a/pcu/PCU_Tests.default
+++ b/pcu/PCU_Tests.default
@@ -13,11 +13,11 @@
 	cell_id := {
 		ra_id := {
 			lai := {
-				mcc_mnc := '00101F'H, lac := 1
+				mcc_mnc := '26242F'H, lac := 13135
 			},
 			rac := 0
 		},
-		cell_id := 0
+		cell_id := 20960
 	},
 	sgsn_role := true
 }

-- 
To view, visit https://gerrit.osmocom.org/13375
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac9be9a8d4ccb4d01cc343d763d2e35873e3844f
Gerrit-Change-Number: 13375
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190327/9a40c601/attachment.html>


More information about the gerrit-log mailing list