Change in osmo-bts[master]: main: remove wrong call to oml_fail_rep() on SIGUSR1/2 and SIGABRT

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 27 11:10:47 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13296 )

Change subject: main: remove wrong call to oml_fail_rep() on SIGUSR1/2 and SIGABRT
......................................................................

main: remove wrong call to oml_fail_rep() on SIGUSR1/2 and SIGABRT

SIGUSR1/2 and SIGABRT should not trigger a failure event report on
OML since we only use it to get an intermediate talloc report. (In
case of SIGUSR1/2 without leaving the process.)

Change-Id: I99e637496afff2530425b89c6e9befc76db24906
---
M src/common/main.c
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/common/main.c b/src/common/main.c
index 3a53813..9575f57 100644
--- a/src/common/main.c
+++ b/src/common/main.c
@@ -192,9 +192,6 @@
 	case SIGABRT:
 	case SIGUSR1:
 	case SIGUSR2:
-		oml_fail_rep(OSMO_EVT_CRIT_PROC_STOP,
-			     "BTS: signal %d (%s) received", signal,
-			     strsignal(signal));
 		talloc_report_full(tall_bts_ctx, stderr);
 		break;
 	default:

-- 
To view, visit https://gerrit.osmocom.org/13296
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I99e637496afff2530425b89c6e9befc76db24906
Gerrit-Change-Number: 13296
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190327/77931f60/attachment.htm>


More information about the gerrit-log mailing list