Change in libosmocore[master]: logging_gsmtap.c: document all params of log_target_create_gsmtap()

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 27 09:53:50 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13400 )

Change subject: logging_gsmtap.c: document all params of log_target_create_gsmtap()
......................................................................

logging_gsmtap.c: document all params of log_target_create_gsmtap()

Change-Id: Id7bd6b4fb4be571af351f77aa4a59b9e1076434f
---
M src/logging_gsmtap.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve



diff --git a/src/logging_gsmtap.c b/src/logging_gsmtap.c
index 98d2aad..bd64271 100644
--- a/src/logging_gsmtap.c
+++ b/src/logging_gsmtap.c
@@ -117,7 +117,11 @@
 }
 
 /*! Create a new logging target for GSMTAP logging
+ *  \param[in] host remote host to send the logs to
+ *  \param[in] port remote port to send the logs to
  *  \param[in] ident string identifier
+ *  \param[in] ofd_wq_mode register osmo_wqueue (1) or not (0)
+ *  \param[in] add_sink add GSMTAP sink or not
  *  \returns Log target in case of success, NULL in case of error
  */
 struct log_target *log_target_create_gsmtap(const char *host, uint16_t port,

-- 
To view, visit https://gerrit.osmocom.org/13400
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7bd6b4fb4be571af351f77aa4a59b9e1076434f
Gerrit-Change-Number: 13400
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190327/55ab821b/attachment.html>


More information about the gerrit-log mailing list