Change in libosmocore[master]: src/msgb.c: fix Doxygen documentation for msgb_printf()

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 27 09:51:55 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13407 )

Change subject: src/msgb.c: fix Doxygen documentation for msgb_printf()
......................................................................

src/msgb.c: fix Doxygen documentation for msgb_printf()

This change fixes the following Doxygen warnings:

  src/msgb.c:479: warning: argument 'msg' of command @param is not
                  found in the argument list of
                  msgb_printf(struct msgb *msgb, const char *format,...)
  core/msgb.h:708: warning: The following parameters of
                   msgb_printf(struct msgb *msgb, const char *format,...)
                   are not documented:
                     parameter 'msgb'
                     parameter 'format'

As a bonus, it dot-terminates all sentences.

Change-Id: Ib708664336eef06f748d408ae02a13c754b6647a
---
M src/msgb.c
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/msgb.c b/src/msgb.c
index 3902f6e..ce7654a 100644
--- a/src/msgb.c
+++ b/src/msgb.c
@@ -476,8 +476,9 @@
 
 
 /*! Print a string to the end of message buffer.
- * \param[in] msg message buffer
- * \returns 0 on success, -EINVAL on error
+ * \param[in] msgb message buffer.
+ * \param[in] format format string.
+ * \returns 0 on success, -EINVAL on error.
  *
  * The resulting string is printed to the msgb without a trailing nul
  * character. A nul following the data tail may be written as an implementation

-- 
To view, visit https://gerrit.osmocom.org/13407
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib708664336eef06f748d408ae02a13c754b6647a
Gerrit-Change-Number: 13407
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190327/fce8a26d/attachment.html>


More information about the gerrit-log mailing list