Change in osmo-bts[master]: oc2g: change log level for calibration file errors to FATAL

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 27 07:58:57 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13266 )

Change subject: oc2g: change log level for calibration file errors to FATAL
......................................................................

oc2g: change log level for calibration file errors to FATAL

The log level of the messages that notify calibration file loading
problems is NOTICE, but since it is a severe problem when calibration
can not be loaded lets change it to FATAL

Change-Id: I32aed25ca7925f1c776f00b37f404a58a85ddbc7
Related: OS#3823
---
M src/osmo-bts-oc2g/calib_file.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-oc2g/calib_file.c b/src/osmo-bts-oc2g/calib_file.c
index ed7aa16..72ec266 100644
--- a/src/osmo-bts-oc2g/calib_file.c
+++ b/src/osmo-bts-oc2g/calib_file.c
@@ -133,7 +133,7 @@
 
 	st->fp = fopen(fname, "rb");
 	if (!st->fp) {
-		LOGP(DL1C, LOGL_NOTICE, "Failed to open '%s' for calibration data.\n", fname);
+		LOGP(DL1C, LOGL_FATAL, "Failed to open '%s' for calibration data.\n", fname);
 		oml_tx_failure_event_rep(&fl1h->phy_inst->trx->mo, OSMO_EVT_WARN_SW_WARN,
 					 "Failed to open '%s' for calibration data", fname);
 		return -1;
@@ -220,7 +220,7 @@
 
 	rc = calib_verify(fl1h, desc);
 	if (rc < 0) {
-		LOGP(DL1C, LOGL_NOTICE,"Verify L1 calibration table %s -> failed (%d)\n", desc->fname, rc);
+		LOGP(DL1C, LOGL_FATAL, "Verify L1 calibration table %s -> failed (%d)\n", desc->fname, rc);
 		oml_tx_failure_event_rep(&fl1h->phy_inst->trx->mo, OSMO_EVT_WARN_SW_WARN,
 					 "Verify L1 calibration table %s -> failed (%d)", desc->fname, rc);
 
@@ -277,7 +277,7 @@
 	char *calib_path = fl1h->phy_inst->u.oc2g.calib_path;
 
 	if (!calib_path) {
-		LOGP(DL1C, LOGL_NOTICE, "Calibration file path not specified\n");
+		LOGP(DL1C, LOGL_FATAL, "Calibration file path not specified\n");
 		oml_tx_failure_event_rep(&fl1h->phy_inst->trx->mo, OSMO_EVT_WARN_SW_WARN,
 					 "Calibration file path not specified");
 		return -1;

-- 
To view, visit https://gerrit.osmocom.org/13266
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I32aed25ca7925f1c776f00b37f404a58a85ddbc7
Gerrit-Change-Number: 13266
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: Max <msuraev at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190327/e09b0794/attachment.html>


More information about the gerrit-log mailing list