Change in pysim[master]: sysmo-usim-sjs1: update EF.AD with correct MNC length

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 27 07:27:13 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13366 )

Change subject: sysmo-usim-sjs1: update EF.AD with correct MNC length
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/#/c/13366/3/pySim/cards.py
File pySim/cards.py:

https://gerrit.osmocom.org/#/c/13366/3/pySim/cards.py@121
PS3, Line 121: 	def update_ad(self, mnc):
so this is part of the generic "card" class...


https://gerrit.osmocom.org/#/c/13366/3/pySim/cards.py@603
PS3, Line 603:                 # EF.AD
but it's used only from the sysmoUSIM-SJS1 specicic code.  However, the other cards likely have exactly the same problem.  I hope there's nothing card-model specific about writing EF.AD (a standard file) and hence I would assume we can simply make this common to all card typeS?  If there are cards where writing the file is not allowed, then we have to at least copy this block to all cards that do support it.



-- 
To view, visit https://gerrit.osmocom.org/13366
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I827092b2c7f7952f54b2d9f8dbda419a0dbfaf65
Gerrit-Change-Number: 13366
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Wed, 27 Mar 2019 07:27:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190327/2b50cb64/attachment.html>


More information about the gerrit-log mailing list