Change in osmo-bsc[master]: nanobts: use libosmocore's osmo_store*() for OML attr. patching

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 27 07:09:24 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13418 )

Change subject: nanobts: use libosmocore's osmo_store*() for OML attr. patching
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

https://gerrit.osmocom.org/#/c/13418/1/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c
File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:

https://gerrit.osmocom.org/#/c/13418/1/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c@202
PS1, Line 202: 	buf[0] = bts->gprs.nsvc[0].nsvci >> 8;
> Aren't these 2 lines assuming the code runs on a little endian system? afaiu it converts nsvci to bi […]
your assessment appears correct.  This should be fixed in an independent patch/fix.


https://gerrit.osmocom.org/#/c/13418/1/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c@207
PS1, Line 207: 	osmo_store16be(bts->gprs.nsvc[0].remote_port, &buf[0]);
> Be careful, you are changing the result/encoding here. […]
but the previous patch_16/32() always had a htons/htonl inside, so I think for this line and the two instances below for remoote ip and local udp port are functionally equivalent, AFAICT.



-- 
To view, visit https://gerrit.osmocom.org/13418
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28cfb09f224072db9889a89923a3da15a6070e2a
Gerrit-Change-Number: 13418
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Mar 2019 07:09:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190327/7840ce1b/attachment.html>


More information about the gerrit-log mailing list